Merged
Conversation
Leeyoonji23
requested review from
jisooooooooooo,
kwonsaebom and
shinjigu
as code owners
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
jisooooooooooo
approved these changes
Jul 9, 2025
Collaborator
jisooooooooooo
left a comment
jisooooooooooo
left a comment
There was a problem hiding this comment.
대공사 고생하셨네요 👷🏻🚧
확인했어욤~ ~ ~
shinjigu
approved these changes
Jul 9, 2025
Contributor
shinjigu
left a comment
shinjigu
left a comment
There was a problem hiding this comment.
Small 사이즈 추가도 깔끔하게 처리하셨네요 👷🏻🛠️ 파일 구조 개선까지 수고하셨습니다 !!
| const [selectedGoal, setSelectedGoal] = useState<number | null>(null); | ||
|
|
||
| const handleGoalClick = (position: number) => { | ||
| setSelectedGoal(selectedGoal === position ? null : position); |
| }, | ||
| selectors: { | ||
| '&[data-completed="true"]': { | ||
| border: '0.4rem solid #305088', |
Contributor
There was a problem hiding this comment.
p1) 하드코딩된 색상값 고쳐주시면 좋을 것 같습니다 🕶️
kwonsaebom
approved these changes
Jul 9, 2025
Contributor
kwonsaebom
left a comment
kwonsaebom
left a comment
There was a problem hiding this comment.
수고 많으셨습니다 !! 코드 너무 깔끔하네여 .. 😻👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
✅ Tasks
👀 To Reviewer
사용방법은
입니다
변경사항은 스토리북 확인해주세요!
📸 Screenshot